Code review comment for lp:~alan-griffiths/qtmir/introducing-QtmirWindowManagementPolicy

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 27/11/2015 08:18, Alan Griffiths wrote:
>> """
>> void QtmirWindowManagementPolicy::generate_decorations_for(
>> """
>>
>> Why would Mir or even QtMir have anything to do with window decorations?
> If as you suggest QtMir does not have anything to do with window decorations this function can keep the proposed null implementation. However, other clients of Mir *do* work with decorations. E.g. mir_demo_server and mir_proving_server draw titlebars.
>
> Alternatively, we can come up with a more general approach then we can change the code here and port it back to Mir.

But those barebones pure Mir+OpenGL are not very realistic examples of
shell implementations (apart from, maybe, some dumb kiosks or the like).
Any minimally complex shell will likely use a toolkit to help out with
animations etc. And they most likely have their own scene
implementation, like Qt/QML.

« Back to merge proposal