Code review comment for lp:~alan-griffiths/miral/rework-handling-of-surface-state-changes

> - policy->advise_state_change(window_info, value);
> - window_info.state(value);
> - mir_surface->hide();
> - mir_surface->configure(mir_surface_attrib_state, value);
> - if (window_info.window() == active_window())
> - {
> - mru_active_windows.erase(window_info.window());
> -
> - // Try to activate to recently active window of any application
> - mru_active_windows.enumerate([&](Window& window)
> - {
> - auto const w = window;
> - return !(select_active_window(w));
> - });
> - }
> - return;
>
> I wasn't expecting this to vanish in this MP. Is it dead code?

Neither.

+ if (window == active_window())
+ {
+ // Try to activate to recently active window of any application
+ mru_active_windows.enumerate([&](Window& candidate)
+ {
+ if (candidate == window)
+ return true;
+ auto const w = candidate;
+ return !(select_active_window(w));
+ });
+ }

Plus some duplicated code consolidated.