Merge lp:~alan-griffiths/miral/remove-properties-WM-ignores into lp:miral

Proposed by Alan Griffiths
Status: Merged
Approved by: Gerry Boland
Approved revision: 311
Merged at revision: 315
Proposed branch: lp:~alan-griffiths/miral/remove-properties-WM-ignores
Merge into: lp:miral
Diff against target: 115 lines (+0/-32)
4 files modified
debian/libmiral1.symbols (+0/-5)
include/miral/window_specification.h (+0/-4)
miral/symbols.map (+0/-3)
miral/window_specification.cpp (+0/-20)
To merge this branch: bzr merge lp:~alan-griffiths/miral/remove-properties-WM-ignores
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+304906@code.launchpad.net

Commit message

Remove pixel_format, buffer_usage and content_id properties from WindowSpecification as they are not used by Window Management

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

QtMir does need this info for compositing, but mir::shell::Surface has similar getters which we're using and which do the job.

I'm ok with this, as they're not WM specific info

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/libmiral1.symbols'
--- debian/libmiral1.symbols 2016-08-29 09:19:00 +0000
+++ debian/libmiral1.symbols 2016-09-05 10:44:19 +0000
@@ -189,9 +189,6 @@
189 (c++)"miral::WindowSpecification::aux_rect_placement_gravity()@MIRAL_0.1" 0.1.0189 (c++)"miral::WindowSpecification::aux_rect_placement_gravity()@MIRAL_0.1" 0.1.0
190 (c++)"miral::WindowSpecification::aux_rect_placement_offset() const@MIRAL_0.1" 0.1.0190 (c++)"miral::WindowSpecification::aux_rect_placement_offset() const@MIRAL_0.1" 0.1.0
191 (c++)"miral::WindowSpecification::aux_rect_placement_offset()@MIRAL_0.1" 0.1.0191 (c++)"miral::WindowSpecification::aux_rect_placement_offset()@MIRAL_0.1" 0.1.0
192 (c++)"miral::WindowSpecification::buffer_usage() const@MIRAL_0.1" 0.1.0
193 (c++)"miral::WindowSpecification::buffer_usage()@MIRAL_0.1" 0.1.0
194 (c++)"miral::WindowSpecification::content_id()@MIRAL_0.1" 0.1.0
195 (c++)"miral::WindowSpecification::height_inc() const@MIRAL_0.1" 0.1.0192 (c++)"miral::WindowSpecification::height_inc() const@MIRAL_0.1" 0.1.0
196 (c++)"miral::WindowSpecification::height_inc()@MIRAL_0.1" 0.1.0193 (c++)"miral::WindowSpecification::height_inc()@MIRAL_0.1" 0.1.0
197 (c++)"miral::WindowSpecification::input_mode() const@MIRAL_0.1" 0.1.0194 (c++)"miral::WindowSpecification::input_mode() const@MIRAL_0.1" 0.1.0
@@ -217,8 +214,6 @@
217 (c++)"miral::WindowSpecification::output_id()@MIRAL_0.1" 0.1.0214 (c++)"miral::WindowSpecification::output_id()@MIRAL_0.1" 0.1.0
218 (c++)"miral::WindowSpecification::parent() const@MIRAL_0.1" 0.1.0215 (c++)"miral::WindowSpecification::parent() const@MIRAL_0.1" 0.1.0
219 (c++)"miral::WindowSpecification::parent()@MIRAL_0.1" 0.1.0216 (c++)"miral::WindowSpecification::parent()@MIRAL_0.1" 0.1.0
220 (c++)"miral::WindowSpecification::pixel_format() const@MIRAL_0.1" 0.1.0
221 (c++)"miral::WindowSpecification::pixel_format()@MIRAL_0.1" 0.1.0
222 (c++)"miral::WindowSpecification::placement_hints() const@MIRAL_0.1" 0.1.0217 (c++)"miral::WindowSpecification::placement_hints() const@MIRAL_0.1" 0.1.0
223 (c++)"miral::WindowSpecification::placement_hints()@MIRAL_0.1" 0.1.0218 (c++)"miral::WindowSpecification::placement_hints()@MIRAL_0.1" 0.1.0
224 (c++)"miral::WindowSpecification::preferred_orientation() const@MIRAL_0.1" 0.1.0219 (c++)"miral::WindowSpecification::preferred_orientation() const@MIRAL_0.1" 0.1.0
225220
=== modified file 'include/miral/window_specification.h'
--- include/miral/window_specification.h 2016-08-29 14:26:01 +0000
+++ include/miral/window_specification.h 2016-09-05 10:44:19 +0000
@@ -133,8 +133,6 @@
133133
134 auto top_left() const -> mir::optional_value<Point> const&;134 auto top_left() const -> mir::optional_value<Point> const&;
135 auto size() const -> mir::optional_value<Size> const&;135 auto size() const -> mir::optional_value<Size> const&;
136 auto pixel_format() const -> mir::optional_value<MirPixelFormat> const&;
137 auto buffer_usage() const -> mir::optional_value<BufferUsage> const&;
138 auto name() const -> mir::optional_value<std::string> const&;136 auto name() const -> mir::optional_value<std::string> const&;
139 auto output_id() const -> mir::optional_value<int> const&;137 auto output_id() const -> mir::optional_value<int> const&;
140 auto type() const -> mir::optional_value<MirSurfaceType> const&;138 auto type() const -> mir::optional_value<MirSurfaceType> const&;
@@ -162,13 +160,11 @@
162 auto top_left() -> mir::optional_value<Point>&;160 auto top_left() -> mir::optional_value<Point>&;
163 auto size() -> mir::optional_value<Size>&;161 auto size() -> mir::optional_value<Size>&;
164 auto pixel_format() -> mir::optional_value<MirPixelFormat>&;162 auto pixel_format() -> mir::optional_value<MirPixelFormat>&;
165 auto buffer_usage() -> mir::optional_value<BufferUsage>&;
166 auto name() -> mir::optional_value<std::string>&;163 auto name() -> mir::optional_value<std::string>&;
167 auto output_id() -> mir::optional_value<int>&;164 auto output_id() -> mir::optional_value<int>&;
168 auto type() -> mir::optional_value<MirSurfaceType>&;165 auto type() -> mir::optional_value<MirSurfaceType>&;
169 auto state() -> mir::optional_value<MirSurfaceState>&;166 auto state() -> mir::optional_value<MirSurfaceState>&;
170 auto preferred_orientation() -> mir::optional_value<MirOrientationMode>&;167 auto preferred_orientation() -> mir::optional_value<MirOrientationMode>&;
171 auto content_id() -> mir::optional_value<BufferStreamId>&;
172 auto aux_rect() -> mir::optional_value<Rectangle>&;168 auto aux_rect() -> mir::optional_value<Rectangle>&;
173 auto placement_hints() -> mir::optional_value<MirPlacementHints>&;169 auto placement_hints() -> mir::optional_value<MirPlacementHints>&;
174 auto window_placement_gravity() -> mir::optional_value<MirPlacementGravity>&;170 auto window_placement_gravity() -> mir::optional_value<MirPlacementGravity>&;
175171
=== modified file 'miral/symbols.map'
--- miral/symbols.map 2016-08-29 09:19:00 +0000
+++ miral/symbols.map 2016-09-05 10:44:19 +0000
@@ -165,8 +165,6 @@
165 miral::WindowSpecification::aux_rect*;165 miral::WindowSpecification::aux_rect*;
166 miral::WindowSpecification::aux_rect_placement_gravity*;166 miral::WindowSpecification::aux_rect_placement_gravity*;
167 miral::WindowSpecification::aux_rect_placement_offset*;167 miral::WindowSpecification::aux_rect_placement_offset*;
168 miral::WindowSpecification::buffer_usage*;
169 miral::WindowSpecification::content_id*;
170 miral::WindowSpecification::height_inc*;168 miral::WindowSpecification::height_inc*;
171 miral::WindowSpecification::input_mode*;169 miral::WindowSpecification::input_mode*;
172 miral::WindowSpecification::input_shape*;170 miral::WindowSpecification::input_shape*;
@@ -180,7 +178,6 @@
180 miral::WindowSpecification::operator*;178 miral::WindowSpecification::operator*;
181 miral::WindowSpecification::output_id*;179 miral::WindowSpecification::output_id*;
182 miral::WindowSpecification::parent*;180 miral::WindowSpecification::parent*;
183 miral::WindowSpecification::pixel_format*;
184 miral::WindowSpecification::placement_hints*;181 miral::WindowSpecification::placement_hints*;
185 miral::WindowSpecification::preferred_orientation*;182 miral::WindowSpecification::preferred_orientation*;
186 miral::WindowSpecification::shell_chrome*;183 miral::WindowSpecification::shell_chrome*;
187184
=== modified file 'miral/window_specification.cpp'
--- miral/window_specification.cpp 2016-08-29 11:17:18 +0000
+++ miral/window_specification.cpp 2016-09-05 10:44:19 +0000
@@ -394,16 +394,6 @@
394 return self->size;394 return self->size;
395}395}
396396
397auto miral::WindowSpecification::pixel_format() const -> mir::optional_value<MirPixelFormat> const&
398{
399 return self->pixel_format;
400}
401
402auto miral::WindowSpecification::buffer_usage() const -> mir::optional_value<BufferUsage> const&
403{
404 return self->buffer_usage;
405}
406
407auto miral::WindowSpecification::name() const -> mir::optional_value<std::string> const&397auto miral::WindowSpecification::name() const -> mir::optional_value<std::string> const&
408{398{
409 return self->name;399 return self->name;
@@ -534,11 +524,6 @@
534 return self->pixel_format;524 return self->pixel_format;
535}525}
536526
537auto miral::WindowSpecification::buffer_usage() -> mir::optional_value<BufferUsage>&
538{
539 return self->buffer_usage;
540}
541
542auto miral::WindowSpecification::name() -> mir::optional_value<std::string>&527auto miral::WindowSpecification::name() -> mir::optional_value<std::string>&
543{528{
544 return self->name;529 return self->name;
@@ -564,11 +549,6 @@
564 return self->preferred_orientation;549 return self->preferred_orientation;
565}550}
566551
567auto miral::WindowSpecification::content_id() -> mir::optional_value<BufferStreamId>&
568{
569 return self->content_id;
570}
571
572auto miral::WindowSpecification::aux_rect() -> mir::optional_value<Rectangle>&552auto miral::WindowSpecification::aux_rect() -> mir::optional_value<Rectangle>&
573{553{
574 return self->aux_rect;554 return self->aux_rect;

Subscribers

People subscribed via source and target branches