Merge lp:~alan-griffiths/miral/miral-hosted into lp:miral

Proposed by Alan Griffiths
Status: Merged
Approved by: Alan Griffiths
Approved revision: 472
Merged at revision: 469
Proposed branch: lp:~alan-griffiths/miral/miral-hosted
Merge into: lp:miral
Diff against target: 96 lines (+61/-1)
4 files modified
debian/miral-examples.install (+1/-0)
miral-shell/CMakeLists.txt (+8/-0)
miral-shell/desktop/CMakeLists.txt (+1/-1)
miral-shell/miral-app.sh (+51/-0)
To merge this branch: bzr merge lp:~alan-griffiths/miral/miral-hosted
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+313211@code.launchpad.net

Commit message

[examples] add miral-app script for launching hosted by an existing desktop

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

This still isn't ideal in the Mir-on-Mir (a.k.a. MirAL-on-Unity8) scenario as the "nested" Mir support tries to be fullscreen.

470. By Alan Griffiths

miral-hosted => miral-app

471. By Alan Griffiths

miral-hosted => miral-app

Revision history for this message
Gerry Boland (gerboland) wrote :

 ~/dev/projects/mir/miral/miral-hosted/miral-shell ⮀ ll
<snip>
-rw-r--r-- 1 gerry gerry 1822 Dec 14 11:25 miral-app.sh
-rwxr-xr-x 1 gerry gerry 1680 Dec 14 11:25 miral-desktop.sh*
-rwxr-xr-x 1 gerry gerry 207 Dec 14 11:25 miral-run.sh*
-rwxr-xr-x 1 gerry gerry 1774 Dec 14 11:25 miral-screencast.sh*
-rwxr-xr-x 1 gerry gerry 241 Dec 14 11:25 miral-xrun.sh*

miral-app.sh doesn't have same permissions out of the box as the other scripts

Revision history for this message
Gerry Boland (gerboland) wrote :

Other than that, works ok

review: Approve
472. By Alan Griffiths

add execute permission

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/miral-examples.install'
--- debian/miral-examples.install 2016-11-16 10:40:15 +0000
+++ debian/miral-examples.install 2016-12-14 11:39:37 +0000
@@ -4,5 +4,6 @@
4usr/bin/miral-xrun4usr/bin/miral-xrun
5usr/bin/miral-screencast5usr/bin/miral-screencast
6usr/bin/miral-desktop6usr/bin/miral-desktop
7usr/bin/miral-app
7usr/share/applications/miral-shell.desktop8usr/share/applications/miral-shell.desktop
8usr/share/icons/hicolor/scalable/apps/ubuntu-logo.svg9usr/share/icons/hicolor/scalable/apps/ubuntu-logo.svg
910
=== modified file 'miral-shell/CMakeLists.txt'
--- miral-shell/CMakeLists.txt 2016-11-16 10:40:15 +0000
+++ miral-shell/CMakeLists.txt 2016-12-14 11:39:37 +0000
@@ -33,6 +33,14 @@
33 DESTINATION ${CMAKE_INSTALL_PREFIX}/bin33 DESTINATION ${CMAKE_INSTALL_PREFIX}/bin
34)34)
3535
36add_custom_target(miral-app ALL
37 cp ${CMAKE_CURRENT_SOURCE_DIR}/miral-app.sh ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/miral-app
38)
39
40install(PROGRAMS ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/miral-app
41 DESTINATION ${CMAKE_INSTALL_PREFIX}/bin
42)
43
36add_executable(miral-shell44add_executable(miral-shell
37 shell_main.cpp45 shell_main.cpp
38 tiling_window_manager.cpp tiling_window_manager.h46 tiling_window_manager.cpp tiling_window_manager.h
3947
=== modified file 'miral-shell/desktop/CMakeLists.txt'
--- miral-shell/desktop/CMakeLists.txt 2016-04-12 15:59:54 +0000
+++ miral-shell/desktop/CMakeLists.txt 2016-12-14 11:39:37 +0000
@@ -1,5 +1,5 @@
1set(ICON_NAME ubuntu-logo)1set(ICON_NAME ubuntu-logo)
2set(PROGRAM_NAME miral-shell)2set(PROGRAM_NAME miral-app)
33
4configure_file(miral-shell.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/miral-shell.desktop @ONLY)4configure_file(miral-shell.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/miral-shell.desktop @ONLY)
55
66
=== added file 'miral-shell/miral-app.sh'
--- miral-shell/miral-app.sh 1970-01-01 00:00:00 +0000
+++ miral-shell/miral-app.sh 2016-12-14 11:39:37 +0000
@@ -0,0 +1,51 @@
1#! /bin/bash
2
3miral_server=miral-shell
4launcher='gnome-terminal --app-id com.canonical.miral.Terminal'
5hostsocket=
6bindir=
7
8if [ -n "${MIR_SOCKET}" ]
9then
10 if [ ! -e "${MIR_SOCKET}" ]
11 then
12 echo "Error: Host endpoint '${MIR_SOCKET}' does not exists"; exit 1
13 fi
14 i=0; while [ -e "${XDG_RUNTIME_DIR}/mir_socket{i}" ]; do let i+=1 ;done
15 socket=${XDG_RUNTIME_DIR}/mir_socket{i}
16 hostsocket='--host-socket ${MIR_SOCKET}'
17else
18 socket=${XDG_RUNTIME_DIR}/mir_socket
19fi
20
21while [ $# -gt 0 ]
22do
23 if [ "$1" == "--help" -o "$1" == "-h" ]
24 then
25 echo "$(basename $0) - Handy launch script for a hosted miral \"desktop session\""
26 echo "Usage: $0 [options] [shell options]"
27 echo "Options are:"
28 echo " -kiosk use miral-kiosk instead of ${miral_server}"
29 echo " -launcher <launcher> use <launcher> instead of '${launcher}'"
30 echo " -socket <socket> set the mir socket [${socket}]"
31 echo " -bindir <bindir> path to the miral executable"
32 exit 0
33 elif [ "$1" == "-kiosk" ]; then miral_server=miral-kiosk
34 elif [ "$1" == "-launcher" ]; then shift; launcher=$1
35 elif [ "$1" == "-socket" ]; then shift; socket=$1
36 elif [ "$1" == "-bindir" ]; then shift; bindir=$1/
37 elif [ "${1:0:2}" == "--" ]; then break
38 fi
39 shift
40done
41
42if [ -e "${socket}" ]; then echo "Error: session endpoint '${socket}' already exists"; exit 1 ;fi
43
44sh -c "${bindir}${miral_server} $* ${hostsocket} --file ${socket} --desktop_file_hint=miral-shell.desktop"&
45
46while [ ! -e "${socket}" ]; do echo "waiting for ${socket}"; sleep 1 ;done
47
48unset QT_QPA_PLATFORMTHEME
49MIR_SOCKET=${socket} GDK_BACKEND=mir QT_QPA_PLATFORM=ubuntumirclient SDL_VIDEODRIVER=mir dbus-run-session -- ${launcher}
50killall ${bindir}${miral_server}
51

Subscribers

People subscribed via source and target branches