MirAL

Code review comment for lp:~alan-griffiths/miral/fix-FTBFS-on-Xenial-with-Mir-0.27

  1. fix-FTBFS-on-Xenial-with-Mir-0.27
  2. Merge into trunk
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Compiles ok!
>
> Nitpicking: EXPECT_THAT(cookie, Ne(nullptr)) could be EXPECT_NE(nullptr,
> cookie);
> (Google also seems to want the expected value to be first)

I think "EXPECT_THAT(cookie, Ne(nullptr))" reads better than "EXPECT_NE(nullptr, cookie)"

« Back to merge proposal