Code review comment for lp:~alan-griffiths/miral/fix-1705973

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Explaining better:
> Before this patch, yes the spinnytriangle is always on top of the splash. With
> this patch, there is a flicker where the triangle starts before the splash
> seems to, and then z order changes rapidly when the splash appears on top

I don't see that here (yet).

But there is a potential race when adjusting the z-order and the triangle could potentially paint its few frames before the spinner is (re)placed over it.

Can we file that as a separate bug? I think we need new Mir APIs to control the Z-order directly (or "layers") to avoid it completely.

« Back to merge proposal