Merge lp:~alan-griffiths/miral/fix-1632325 into lp:miral

[Alan Griffiths]

Prior to Mir-0.25 mir_connection_create_spec_for_tooltip() doesn't set an edge attachment preference. So give it one.

[Gerry Boland (gerboland)]

LGTM

review: Approve

[Brandon Schaefer (brandontschaefer)]

lgtm

review: Approve

=== modified file 'miral/window_specification.cpp'
--- miral/window_specification.cpp	2016-09-30 16:29:43 +0000
+++ miral/window_specification.cpp	2016-10-11 14:18:52 +0000
@@ -250,6 +250,16 @@
         aux_rect_placement_offset = Displacement{params.aux_rect_placement_offset_x.value(), params.aux_rect_placement_offset_y.value()};
 #endif
 
+#if MIR_SERVER_VERSION < MIR_VERSION_NUMBER(0, 25, 0)
+    // mir_connection_create_spec_for_tooltip() didn't set an edge_attachment preference
+    if (aux_rect.is_set() && !params.edge_attachment.is_set())
+    {
+        window_placement_gravity = mir_placement_gravity_northwest;
+        aux_rect_placement_gravity = mir_placement_gravity_northeast;
+        placement_hints = mir_placement_hints_flip_any;
+    }
+#endif
+
     if (params.edge_attachment.is_set() && !placement_hints.is_set())
     {
         switch (params.edge_attachment.value())