Merge lp:~alan-griffiths/miral/fix-1616818 into lp:miral

[Alan Griffiths]

Impose rules for interactive window movement

Impose rules for interactive window movement. Vis:

"When a surface is moved interactively

"Regular, floating regular, dialog, and satellite surfaces should be user-movable. Popups, glosses, and tips should not be. Freestyle surfaces may or may not be, as specified by the app."

[Gerry Boland (gerboland)]

Not worth a test?

review: Approve

[Alan Griffiths (alan-griffiths)]

> Not worth a test?

It is.

I'll land this as a bugfix and follow up with a test fixture for probing miral::WindowManagerTools behaviour with this as the first test.

=== modified file 'miral/basic_window_manager.cpp'
--- miral/basic_window_manager.cpp	2016-09-07 20:23:20 +0000
+++ miral/basic_window_manager.cpp	2016-09-15 09:34:03 +0000
@@ -895,7 +895,28 @@
 
     auto& window_info = info_for(window);
 
-    // placeholder - constrain onscreen
+    // When a surface is moved interactively
+    // -------------------------------------
+    // Regular, floating regular, dialog, and satellite surfaces should be user-movable.
+    // Popups, glosses, and tips should not be.
+    // Freestyle surfaces may or may not be, as specified by the app.
+    //                              Mir and Unity: Surfaces, input, and displays (v0.3)
+    switch (window_info.type())
+    {
+    case mir_surface_type_normal:   // regular
+    case mir_surface_type_utility:  // floating regular
+    case mir_surface_type_dialog:   // dialog
+    case mir_surface_type_satellite:// satellite
+    case mir_surface_type_freestyle:// freestyle
+        break;
+
+    case mir_surface_type_gloss:
+    case mir_surface_type_menu:
+    case mir_surface_type_inputmethod:
+    case mir_surface_type_tip:
+    case mir_surface_types:
+        return;
+    }
 
     switch (window_info.state())
     {