MirAL

Code review comment for lp:~alan-griffiths/miral/encapsulate-mir-PromptSession

  1. encapsulate-mir-PromptSession
  2. Merge into trunk
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> General change looks ok, however I'd prefer if you adopted the Qt style in
> PromptSession, e.g.
> std::shared_ptr<mir::scene::PromptSession> const& promptSession
> -> const std::shared_ptr<mir::scene::PromptSession> &promptSession
> and not use the newer C++ style "auto foo() -> bool"

Done

« Back to merge proposal