Code review comment for lp:~alan-griffiths/miral/background-intro

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Works ok.
>
> + for (int i = 0; i < region->width; i++)
> + memcpy(pixel + i, pattern, sizeof pixel[i]);
> This can't be a single memcpy?

Only if region->width <= 1 (otherwise we access beyond the end of pattern).

« Back to merge proposal