Mir

Code review comment for lp:~alan-griffiths/mir/workaround-1525003

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I'm still not convinced this is theoretically correct. If the "mir_surface_set_state(surface, mir_surface_state_fullscreen);" contributes anything to the test then it will only do so if the request is completed in time. If the surface is not full screen before we do cursor tinkering then either some test may fail, or you didn't need the fullscreening in the first place.

I know that the server presently completes most requests in order, but don't think we document that, or should document that.

Needs another reviewer.

« Back to merge proposal