Mir

Code review comment for lp:~alan-griffiths/mir/workaround-1525003

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> mir_surface_set_state is asynchronous and you're not waiting for it. That's a
> feature which is sometimes useful, but does it put your expectation at risk?

No. Waiting for the RPC call to return doesn't add anything toward the expectation.

> In theory at least our client API allows calls to complete out of order. Maybe
> none do just yet, but that's not something we should assume.

I disagree with that theory. The server should handle calls in the order the client makes them.

« Back to merge proposal