Code review comment for lp:~alan-griffiths/mir/workaround-1525003

mir_surface_set_state is asynchronous and you're not waiting for it. That's a feature which is sometimes useful, but does it put your expectation at risk?

14 + mir_surface_set_state(surface, mir_surface_state_fullscreen);
15 auto conf = mir_cursor_configuration_from_name(mir_disabled_cursor_name);
16 - mir_wait_for(mir_surface_configure_cursor(surface, conf));
17 + mir_surface_configure_cursor(surface, conf);
18 mir_cursor_configuration_destroy(conf);

In theory at least our client API allows calls to complete out of order. Maybe none do just yet, but that's not something we should assume.