Mir

Code review comment for lp:~alan-griffiths/mir/surface-states-simplification

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

"So, msh::Shell, might just be on the point of needing a refactor. (if its constructor is getting "too bloated" of course"

I assume that means msh::Surface?

I too have questioned in the past whether some of the attributes currently being added to shell::Surface are best modeled as member variables. (As opposed to say, their being an event filter that has an associative map from surface to event sink.)

This proposal doesn't address this question.

« Back to merge proposal