Mir

Code review comment for lp:~alan-griffiths/mir/spike-exposing-rpc-in-frontend

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

I like the new version better.

Looks OK, besides some stray tabs:

272 + sender(sender),

819 + std::function<void(boost::system::error_code const&, size_t)> const& callback,
820 + boost::asio::streambuf& stream,
821 + size_t size)
822 + {
823 + read_size = size;
824 + pstream = &stream;
825 + callback_function = callback;831

831 + ASSERT_THAT(callback_function, Ne(nullptr));
839 + callback_function(code, size);

866 + int const header_size = 2;

review: Needs Fixing

« Back to merge proposal