Mir

Code review comment for lp:~alan-griffiths/mir/socket-connection

Revision history for this message
Kevin DuBois (kdub) wrote :

client_socket_fd()
the function looks like its making a new session, and creating an fd for a new client. The name could be create_fd_for_new_client()?

create_session_for()
are we creating a session for the socket? or creating a session with a socket? create_session_from_socket()

those are pretty minor naming issues though, lgtm

review: Approve

« Back to merge proposal