Code review comment for lp:~alan-griffiths/mir/restrict-access-to-private-headers

> I'm slightly uncomfortable with republishing headers no one is using, even
> indirectly. Rather than decide based on the contents of acceptance tests, I
> suggest auditing the downstream projects instead, which would then indicate
> some acceptance tests should not be acceptance tests.

Agreed.

It is clear that Logger ought to be a customization point, so I'm happy with that.

The geometry types are pretty obvious and unlikely to change in problematic ways. There's really no reason to segregate the geometry headers on the basis of which ones happen to be in use right now.

That leaves Clock and BufferWriter:

Clock is only used by benchmarks/frame-uniformity/touch_measuring_client.cpp:21 - so making keeping that private isn't a big deal. Done.

BufferWriter is used by examples/render_overlays.cpp:27 and in stubbing out the graphics "platform". We could demote render_overlays to playground until we have an example that users could and find another way for the tests, but it doesn't seem worth the effort.