Mir

Code review comment for lp:~alan-griffiths/mir/remove-constraints-on-surface-placement

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> That feels better.
>
> (1) This looks like a TODO (which it kind of is, but isn't):
> 46 + // placeholder - constrain onscreen
> If anything in future you'd just want a little logic that ensures a window
> rectangle always intersects the screen rectangle somehow so you don't lose it
> entirely. But even that's not so such an issue with dragging as with display
> layout reconfiguration.
>
> (2) Keep in mind that window snapping would eventually need more than a single
> rectangle:
> 93 + Rectangle const& /*bounds*/)
> You would indeed use a bounding rectangle for the screen, but also the set of
> all window rectangles whose exterior edges can be snapped to.

Agreed

« Back to merge proposal