Mir

Code review comment for lp:~alan-griffiths/mir/placement-notification

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> needs info:
>
> I got a bit confused about what the placement was relevant to, I assume its
> relative to the current position, and this event is to confirm that the
> placement request occurred?

placement requests are relative to the parent, and so is the result.

> + surface_placement_event.cpp
> ${PROJECT_SOURCE_DIR}/src/include/common/mir/events/surface_placement_event.h
>
> why not include_directories?

I don't understand the question, what has include_directories got to do with adding source files?

« Back to merge proposal