Code review comment for lp:~alan-griffiths/mir/move-graphicsplatform-dependencies-to-graphics
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> 1. So the graphics namespace would no longer be used inside libmirserver
> right? Because everything remaining in libmirserver would ideally be moved
> into mir::server:: or grouped more logically in future.
No. Like the protobuf namespace the graphics namespace will be consumed in libmirserver, but implemented in another library.
> 2. Can we think of a better namespace than "mir::graphics::"? It seems silly
> to imply that other components of Mir are not graphics-related. It's all
> graphics-related. So calling the namespace "graphics" does not communicate the
> intention at all. Maybe use "driver" or "platform"...
Possibly, the name originates from the the project startup meeting (and I'm used to it).
I don't think this MP is the right place to change it though - an MP dedicated to changing the name would be far easier to review.