Mir

Code review comment for lp:~alan-griffiths/mir/more-surface-resize

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(1) Still not a fan of the extraneous functions and longer names. And "inc" is better than "increment" because the former is actually more common in programming circles and less likely to take you off the edge of the screen when typing.

(2) Does anyone know why having two aspect ratios is useful? I know X has it, but why? In my experience in building toolkits only two options (one ratio) are useful:
  (a) Fixed aspect ratio (e.g. video player); or
  (b) No fixed aspect ratio (although the toolkit will feed back and modify the min/max dimensions according to how well its widgets fit, that's not an aspect thing).

« Back to merge proposal