Mir

Code review comment for lp:~alan-griffiths/mir/more-surface-resize

Revision history for this message
Kevin DuBois (kdub) wrote :

> > 227+ * Defines an arithmetic progression of sizes starting with min_width
> (if
> > set, otherwise 0)
> > would a default of 1 be better?
>
> I don't follow. If min_width isn't set the series is:
>
> 0, width_inc, 2*width_inc, ...
>
> You're suggesting this:
>
> 1, 1+width_inc, 1+2*width_inc, ...
>
> > That way the server wouldn't be stepping over
> > the clients default of 0 by default. (zero seems to be a request to fix the
> > surface size to min_width, min_height)
>
> And I don't follow this.

So, I was suggesting that min_width is always set and gives the sequence:
min_width, min_width + 1*width_inc, min_width + 2*width_inc, etc
And, with that 1 would be a good default value, because then you get:
min_width, min_width+1, min_width+2, etc.
effectively, saying that the server can resize to any width and still fit within the client's setting.
If min_width is set to zero, then the client's sequence is:
min_width, min_width, min_width, etc...
and the client requests no server resizes.

« Back to merge proposal