Mir

Code review comment for lp:~alan-griffiths/mir/more-surface-resize

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

Nit: + 240 s/hight/height

Maintaining ABI compatibility of caller stored structures seems harder than having separate functions. Given the use cases I can think of right now, most clients might only use the width/height increment functions or the aspect ration functions. Hence those could be combined to single functions. Then again most of the existing setter 'methods' are unary.

review: Approve

« Back to merge proposal