Mir

Code review comment for lp:~alan-griffiths/mir/mir-server-with-add_configuration_option-chaining

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

even if somebody has a use case with a lot of configuration options he or she could do that similar to:

struct add_options
{
    mir::Server * server;
    add_options(Server* server) : server(server){}
    add_options const& operator()(std::string const& option, std::string const& description, int default_value) const
    {
         return server->add_configuration_option(option, description, default_value);
         return *this;
    }
     ....
};

not needing any further support from the mir api. Still I guess nobody will do it, since it requires probably more lines of code than one can gain with it.. So I vote for leaving it out.

review: Abstain

« Back to merge proposal