Code review comment for lp:~alan-griffiths/mir/make-set_logger-for-client-reports
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> Huh. I thought we were trying to make mirclient independent of mircommon? This
> ties them together more.
I don't recognise that aspiration. Nor do I think it feasible.
> As it stands, this is really only going to be useful in tests, right?
Yes.
> I rather
> thought you might take this opportunity to add a client-facing mirclient log
> API (which we need at some point).
Providing a C style API for customizing the logging is a significantly bigger change than this simplification.
> This doesn't seem wrong, though. Unless we haven't given up on making
> mirclient not depend on mircommon?
It could be wrong, if we decide that this mechanism for customizing logging should be deprecated. (See discussion in linked the bug.)