Code review comment for lp:~alan-griffiths/mir/integrate-generic-shell

I am not convinced that GenericShell/WindowManager is the right abstraction to expose, since the WindowManager interface is too strongly coupled conceptually to Shell, and, as mentioned above, GenericShell doesn't contain much logic. The GenericShell brings some convenience, but I am not sure the extra layer of abstraction it adds is worth it vs shell implementers just subclassing AbstractShell.

Alan mentioned in IRC an alternative approach in which WindowManager is exposed and *Shell classes are internal. I like this idea and I think it's worth pursuing it further. My only concern is that the WindowManager interface won't be enough for clients that have other shell needs (e.g. need to handle prompt sessions specially), but my experience in that area is limited.

All that being said, this MP seems like a reasonable starting point for further investigation and experimentation.