Mir

Code review comment for lp:~alan-griffiths/mir/integrate-generic-shell

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Looking at GenericShell, it seem to have very little logic in it, mostly
> forwarding calls to the WindowManager interface. It makes me wonder if the
> WindowManager/GenericShell is really needed and ifusers would be happy enough
> with AbstractShell.

I contemplated rolling AbstractShell and GenericShell into one and using WindowManager as the customization point - the only real impediment to doing that is DefaultShell. (U8 makes trivial use of AbstractShell to avoid DefaultShell's behavior but I don't see that being hard to port.)

Given that DefaultShell has window management behavior that could only be described as perverse I'd like like to get rid of it as soon it is possible to change USC (and our examples) to something based on WindowManager.

> 98 #define MIR_EXAMPLE_GENERIC_SHELL_H_

Fixed.

« Back to merge proposal