Mir

Code review comment for lp:~alan-griffiths/mir/in-process-server-test-fixture

  1. in-process-server-test-fixture
  2. Merge into development-branch
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

1. Aren't these two statements potentially in conflict?...
6 + * Copyright © 2013 Canonical Ltd.
20 + * Authored by: Alan Griffiths <email address hidden>
Should you be putting your Canonical email address there instead?

2. Local variable "display_server" masks member variable of the same name:
214 +mir::DisplayServer* mtf::InProcessServer::start_mir_server()
If would be clearer to use a different name.

review: Needs Fixing

« Back to merge proposal