Mir

Code review comment for lp:~alan-griffiths/mir/improve-tidy-up-of-mir_connection_get_display_info

Revision history for this message
kevin gunn (kgunn72) wrote :

granted i don't touch code everyday, but it does seem to me that RAII is an accepted paradigm that was created to avoid orphaning objects from an owning objects excpetion (...a good thing)
at the same time, Could some additional pointed comments be added to the code to solve the maintainability concern ?

note...i don't agree that we should look at code size generically as a measuring stick...i've certainly seen it go the other way where people trying to "shrink" code made it more enigmatic.

I would propose some comments to be added as to what the deleter is doing, how it helps in the exception instance...then call this good

« Back to merge proposal