Mir

Code review comment for lp:~alan-griffiths/mir/improve-tidy-up-of-mir_connection_get_display_info

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> There are no return statements. The flow of mir_connection_get_display_info is
> very clear as it's not a long function.

There were in the version you referred to in "the increase in code size (+19/-9)." The alternative fix I mentioned removed them (-c 1120 on development-branch).

Explicit deletion is problematic in the presence of exceptions (which shouldn't apply here) or return statements (which we've just discussed).

It is reasonable to prefer uniform use of RAII for cleanup.

« Back to merge proposal