Mir

Code review comment for lp:~alan-griffiths/mir/helptext-mentions-config-file

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good from a functionality perspective.

A couple of formatting issues:

13+ DefaultConfiguration(
14+ int argc, char const* argv[], std::function <void(
15+ int argc, char const* const* argv)> const& handler);

Clearer if std::function<> is on its own line (i.e. like it was before), instead of breaking after the parenthesis.

16+ DefaultConfiguration(
17+ int argc, char const* argv[], std::function <void(
18+ int argc, char const* const* argv)> const& handler,
19+ std::string const& config_file);

Clearer if std::function<> is on its own line, instead of breaking after the parenthesis.
Also, the indentation is too deep.

51+ DefaultConfiguration(argc, argv, [](int argc, char const* const* argv)
52 {

Clearer (IMO) if [](int argc, ...) is on its own line before the opening brace, to keep the lambda together (i.e. at the same indentation level).

review: Needs Fixing

« Back to merge proposal