Mir

Code review comment for lp:~alan-griffiths/mir/fix-1701308

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Is this reliable?

I had previously discovered that you can't rely on the resize callback occurring before the app starts rendering its first frame:

https://code.launchpad.net/~vanvugt/mir/fix-1686620/+merge/323378

So I guess if you are relying on the callback then the app could render two frames on startup... First at the size it requested, and very soon again at the size the shell requested.

It won't look pretty rendering that first frame at the wrong size so I suggest using the EGL_WIDTH/HEIGHT approach shown above. Sounds like it just got broken by the Mesa-RS changes. So if Mesa is now reporting a bogus EGL_WIDTH/HEIGHT that really needs to be fixed (as a matter of higher priority and also would supersede this proposal).

review: Needs Information

« Back to merge proposal