Mir

Code review comment for lp:~alan-griffiths/mir/fix-1603091

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

20:21:18 /��BUILDDIR��/mir-0.24.0+vivid1582bzr3597/tests/mir_test_framework/executable_path.cpp:60:41: error: the value of the size argument in 'strncat' is too large, might lead to a buffer overflow [-Werror,-Wstrncat-size]
20:21:18 strncat(libpath, "/../lib", sizeof libpath);
20:21:18 ^~~~~~~~~~~~~~
20:21:18 /��BUILDDIR��/mir-0.24.0+vivid1582bzr3597/tests/mir_test_framework/executable_path.cpp:60:41: note: change the argument to be the free space in the destination buffer minus the terminating null byte
20:21:18 strncat(libpath, "/../lib", sizeof libpath);
20:21:18 ^~~~~~~~~~~~~~
20:21:18 sizeof(libpath) - strlen(libpath) - 1
20:21:18 make[3]: Leaving directory '/��BUILDDIR��/mir-0.24.0+vivid1582bzr3597/obj-x86_64-linux-gnu'

« Back to merge proposal