Mir

Code review comment for lp:~alan-griffiths/mir/fix-1555620

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> lgtm.
> force_requests_to_complete() is slated for removal soon, so I don't mind the
> lack of test.

Surely that should means a test is important - to ensure removing the call that's needed here doesn't cause a regression?

But I won't block as I do plan to improve our testing - just not in this MP.

« Back to merge proposal