Mir

Code review comment for lp:~alan-griffiths/mir/fix-1543049

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> I'm unsure whether I should add the following to the selection logic around
> line 60
>
> // Ignore modules from different major versions of Mir
> if (MIR_VERSION_MAJOR != desc->major_version)
> return Selection::persist;
>
> // Ignore modules from more recent minor versions of Mir
> if (MIR_VERSION_MINOR < desc->minor_version)
> return Selection::persist;
>
> Does anyone have an opinion either way?

Answering my own question - that only works for plugins we supply ourselves (with MIR_VERSION based versioning).

« Back to merge proposal