Code review comment for lp:~alan-griffiths/mir/fix-1543049
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> My understanding of the bug is that we have a problem when we load mesa-x11 as
> the graphics module and then load a *different* mesa-x11 as the input module.
> Is that not correct?
Strictly, that's not the scenario described in the linked bug. The bug is that we try to load multiple mesa-x11 input modules.
What you describe is indeed a potential issue as mentioned in the TODO comment.
> Having both the input probe and graphics probe first check if the relevant
> symbol is already by an already-loaded module would fix this.
For reasons I don't yet understand the input probing can (and does) select multiple input modules. The logic to match already-loaded modules so as to reject related candidates but not reject unrelated candidates is not as simple as just looking for a symbol. I'd rather leave that for a future MP (hence the TODO).