Mir

Code review comment for lp:~alan-griffiths/mir/fix-1526658

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Oh I failed to look at the sorting implementation. I assumed it had RAII constructed the SharedLibraries before it sorted them. It actually sorts just the filename strings.

That will teach me to try and comment on code while cooking dinner.

review: Approve

« Back to merge proposal