Mir

Code review comment for lp:~alan-griffiths/mir/fix-1526658

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Manual testing suggests this branch works well. Because mesa.so.2 is never loaded according to MIR_CLIENT_SHARED_LIBRARY_PROBER_REPORT=log.

Unfortunately I can't fully test for the original crash of bug 1526658 because my filesystem insists on finding mesa.so.4 in the directory before mesa.so.2, so it is working around the bug by pure luck.

Approved, but I suggest it might be nicer to stop adding functions to mircommon and instead just glob the directory from inside src/client/probing_client_platform_factory.cpp

review: Approve

« Back to merge proposal