Mir

Merge lp:~alan-griffiths/mir/fix-1522836 into lp:mir

Proposed by Alan Griffiths
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 3219
Proposed branch: lp:~alan-griffiths/mir/fix-1522836
Merge into: lp:mir
Diff against target: 49 lines (+29/-4)
1 file modified
doc/building_source_for_pc.md (+29/-4)
To merge this branch: bzr merge lp:~alan-griffiths/mir/fix-1522836
Reviewer Review Type Date Requested Status
Kevin DuBois (community) Approve
Daniel van Vugt Abstain
PS Jenkins bot (community) continuous-integration Approve
Alberto Aguirre (community) Approve
Review via email: mp+280955@code.launchpad.net

Commit message

doc: clarify the discussion of building and installing Mir

Description of the change

doc: clarify the discussion of building and installing Mir

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3208
http://jenkins.qa.ubuntu.com/job/mir-ci/5891/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5372
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4279
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5325/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/207/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/217
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/217/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/217
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/217/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5322
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5322/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7831/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26229
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/203
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/203/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-xenial-touch/58/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26230

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5891/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

mir-mediumtests-runner-xenial-touch strikes again...

The following packages have unmet dependencies:
 libboost-program-options1.58-dev : Depends: libboost1.58-dev (= 1.58.0+dfsg-3.1ubuntu1) but it is not going to be installed
E: Unmet dependencies. Try 'apt-get -f install' with no packages (or specify a solution).

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

OK.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3209
http://jenkins.qa.ubuntu.com/job/mir-ci/5905/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5394
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4301
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5347
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/221
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/231
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/231/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/231
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/231/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5344
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5344/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7852
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26285
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/217
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/217/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-xenial-touch/74
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26286

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5905/rebuild

review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Do we want to recommend "sudo make install" for system install, or instead demonstrate a non-root local install?...

cmake .. -DCMAKE_INSTALL_PREFIX=$HOME/here
make
make install

Come to think of it, I don't think the "Install Mir" section is something that should be documented. If anyone needs to do either then they are usually already advanced enough to know how to do it (since the procedure is the same for most projects).

Also I would prefer a fix for the bug in code. It's better if things just work and you don't need to read any instructions.

review: Abstain
Revision history for this message
Kevin DuBois (kdub) wrote :

I'd agree that we could leave installing mir off, but lgtm in the name of a step in the right direction.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'doc/building_source_for_pc.md'
--- doc/building_source_for_pc.md 2015-10-05 02:18:18 +0000
+++ doc/building_source_for_pc.md 2015-12-20 19:12:40 +0000
@@ -42,17 +42,42 @@
42 $ make (-j8)42 $ make (-j8)
43 $ ctest43 $ ctest
4444
45
46Running Mir
47-----------
48
49The binaries created in the bin subdirectory can be used directly. For example,
50
51 $ bin/mir_demo_server --launch_client bin/mir_demo_client_multiwin
52
53Other examples described elsewhere in this documentation assume you're using the
54installed version and simply need "bin/" adding to specify the local build.
55
56
57Install Mir
58-----------
59
60*It should not be necessary to install Mir for experimental purposes (see
61"Running Mir" above).* Further, if you are using an Ubuntu derived disto then
62there's likely to be existing Mir binaries elsewhere that may interact badly
63with a second install.
64
45To install Mir just use the normal make install command:65To install Mir just use the normal make install command:
4666
47 $ make install67 $ sudo make install
4868
49This will install the Mir libraries, executable, example clients and header69This will install the Mir libraries, executable, example clients and header
50files to the configured installation location (/usr/local by default). If you70files to the configured installation location (/usr/local by default).
51install to a non-standard location, keep in mind that you will probably need to71
52properly set the PKG_CONFIG_PATH environment variable to allow other72NB You may need "sudo ldconfig" to refresh the cache before the installed
73programs work.
74
75If you install to a non-standard location, keep in mind that you will probably
76need to properly set the PKG_CONFIG_PATH environment variable to allow other
53applications to build against Mir, and LD_LIBRARY_PATH to allow applications to77applications to build against Mir, and LD_LIBRARY_PATH to allow applications to
54find the Mir libraries at runtime.78find the Mir libraries at runtime.
5579
80
56Building Mesa81Building Mesa
57-------------82-------------
5883

Subscribers

People subscribed via source and target branches