Mir

Code review comment for lp:~alan-griffiths/mir/fix-1488500

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Two issues/questions:

Do we know if the older to newer load order important for this bug to occur, or could it be caused by just loading two mesa modules in the future regardless of order?

If it's the latter, then the proposed solution is problematic, since in the future a server that needs to use an older mesa platform will run into the same segfault (e.g., server needs 4, loads mesa.so.5 first, then mesa.so.4).

30 + return atoi(++lhbuf) > atoi(++rhbuf);

Better to use strtol() that's guaranteed to have well defined behavior for all inputs strings.

Needs info/fixing

review: Needs Information

« Back to merge proposal