Mir

Code review comment for lp:~alan-griffiths/mir/fix-1450797

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Server ABI needs bumping, as I think this will change the mangled name of the consume symbol:

9 - virtual void consume(MirEvent const& event) = 0;
10 + virtual void consume(MirEvent const* event) = 0;

Although you're only changing the interface, existing external callers of the function won't be able to find it any more without rebuilding.

So "Approved" pending a mirserver ABI bump.

review: Needs Fixing

« Back to merge proposal