Mir

Code review comment for lp:~alan-griffiths/mir/fix-1415321

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(3) Changing the versions of old-ish symbols from MIR_CLIENT_8 to MIR_CLIENT_8.x I think is an ABI break that will break some existing downstreams. :(

446 +MIR_CLIENT_8.4 {
447 + global:
448 + mir_default_cursor_name;
449 + mir_disabled_cursor_name;
450 + mir_arrow_cursor_name;
451 + mir_busy_cursor_name;
452 + mir_caret_cursor_name;
453 + mir_pointing_hand_cursor_name;
454 + mir_open_hand_cursor_name;
455 + mir_closed_hand_cursor_name;
456 + mir_horizontal_resize_cursor_name;
457 + mir_vertical_resize_cursor_name;
458 + mir_diagonal_resize_bottom_to_top_cursor_name;
459 + mir_diagonal_resize_top_to_bottom_cursor_name;
460 + mir_omnidirectional_resize_cursor_name;
461 + mir_vsplit_resize_cursor_name;
462 + mir_hsplit_resize_cursor_name;
463 +} MIR_CLIENT_8.3;
464 +
465 +MIR_CLIENT_8.5 {
466 + global:
467 + mir_event_get_close_surface_event*;
468 + mir_event_get_input_event*;
469 + mir_event_get_keymap_event*;

(4) Yeah those new wildcards just add a little bit of risk, but no value.

Looks like too much risk of breaking the client ABI still. I vote just resubmit in a simpler form (client ABI 9) after vivid is finalized.

review: Needs Resubmitting

« Back to merge proposal