Mir

Code review comment for lp:~alan-griffiths/mir/fix-1415321

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> I'm not wild about symbols shared between the server and the client being in
> mirclient - the event builders and the cursor names are used in both. Why
> shouldn't they be in mircommon?

libmircommon is "common" between by libmirplatform, libmirclient and libmirserver - it should contain symbols that are used by all three. (There's a follow-up MP that removes some symbols used only by libmirplatform and libmirserver.)

libmirclient is used by libmirserver so why shouldn't it contain symbols shared with the latter?

Practically, the mir_toolkit/event/event.h header obviously belongs in client and is a dependency of the builders so splitting those out into libmircommon would involve some rework.

« Back to merge proposal