Mir

Code review comment for lp:~alan-griffiths/mir/fix-1415321

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(1) This is a big deal:
   34 -Package: libmirclient8
   35 +Package: libmirclient9
We need to discuss this a bit (mir-devel?), as it will require a bunch of packages in vivid to be rebuilt that have never needed rebuilding before. Not your fault. This is probably unavoidable since the bug got released with 0.11.0.

Given we haven't broken the COMMON ABI in a long time, we can afford to wait and not fix the bug until we're ready for a client ABI bump. Maybe resubmit first thing after vivid?...
[Resubmit]

(2) The regression test needs to be enabled in examples/CMakeLists.txt:
   # FIXME: Bug not fixed yet.
   if (MIR_ENABLE_TESTS AND MIR_TEST_CLIENT_ABI)
     # Regression tests for LP: #1415321
[Needs Fixing]

review: Needs Resubmitting

« Back to merge proposal