Code review comment for lp:~alan-griffiths/mir/fix-1314574

153 + auto const ucredp = (struct ucred *) CMSG_DATA(CMSG_FIRSTHDR(&msgh));

C cast.

210 +// Disabled as we can't be sure the mir_demo_client_basic is about

Why depend on mir_demo_client_basic instead of creating a new process and running mir_connect() ourselves? We can also record the actual client PID this way, and compare it directly with what the server got.