Mir

Code review comment for lp:~alan-griffiths/mir/fix-1212518

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good, but...

The uses of the cross process fences I have seen don't really have strict timing requirements. The timeout is used only to expedite an exit in case of a perceived hang. Perhaps a larger value, e.g. 15 seconds, would be a better compromise as the default timeout for wait_for_signal_ready_for().

review: Approve

« Back to merge proposal