Mir

Code review comment for lp:~alan-griffiths/mir/fix-1188451

  1. fix-1188451
  2. Merge into trunk
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Verified the bug is fixed.
>
> 1. Needs fixing: Unused protocol changes:
> src/shared/protobuf/mir_protobuf_wire.proto

OK, that's an unrelated change.

> 2. Query: void mf::ProtobufSocketCommunicator::start()
> I find the structure of this loop a bit confusing. Can it be simplified?

Would using "break" in place of "return" help? (I don't feel that introducing a goto or a loop variable simplifies in this case.)

« Back to merge proposal