Mir

Code review comment for lp:~alan-griffiths/mir/fix-1188451

  1. fix-1188451
  2. Merge into trunk
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Verified the bug is fixed.

1. Needs fixing: Unused protocol changes:
src/shared/protobuf/mir_protobuf_wire.proto

2. Query: void mf::ProtobufSocketCommunicator::start()
I find the structure of this loop a bit confusing. Can it be simplified?

review: Needs Fixing

« Back to merge proposal