Mir

Code review comment for lp:~alan-griffiths/mir/fix-1188451

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Regression: The Mir server now wakes up 10 times per second, even when all clients are idle. That's bad. The reason is:

32 + io_service.post([&]
33 + {
34 + do
35 + {
36 + std::this_thread::sleep_for(std::chrono::milliseconds(100));
37 + connected_sessions->discard_disconnected();
38 + }
39 + while (!io_service.stopped());
40 + });

That has to be re-thought because polling is not an option.

An example of a well-behaved almost-idling client to test is mir_demo_client_fingerpaint when you don't move the pointer. And you can install and run powertop (from a remote login) to watch wakeups.

review: Needs Fixing

« Back to merge proposal