Mir

Code review comment for lp:~alan-griffiths/mir/first-pass-of-surface-spec-modification

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks sensible.

31 +void mir_surface_set_title(MirSurface* surface, char const* name);

Now that we have a way to perform the same task with a more general mechanism, I am not convinced that we should keep mir_surface_set_title. If we keep it then we will be tempted to add mir_surface_set_ATTR for every new attribute that can be changed. I prefer offering a single way to do things, even if it's slightly more complex (which is not much of a problem considering that we don't expect most clients to be written with the client API itself, but rather through toolkits).

review: Approve

« Back to merge proposal